Broken scripts.

[DARTrider]

Hey JR team, I've got a bunch of engines that are using some form or another of your "Jointed Rail Train Effects library" in multiple versions. However, a dozen or so models using your script are bugging out, and not displaying class lights, allowing animations to change and turning on various functions. Here's the list of affected engines that are publicly available, it contains a list of several JR products and one or two Control Point freeware engines:

ATSF GP35u <kuid2:37581:10035:1> (JR Club Car)
BDRV GP7 <kuid:506034:587807> (JR Club Car)
DRGW GP40 <kuid2:37581:10041:1> (JR Payware)
GN SW1500 <kuid:750532:101962> (Control Point Freeware)
RI GP7R <kuid:506034:450053> (JR Payware)
RI SW1500 Red <kuid:750532:101864> (Control Point Freeware)
RI SW1500 Late <kuid:750532:102460> (Control Point Freeware)
RPPX GP9 Chop <kuid:506034:250689> (JR Payware, Coal Country)
RPPX GP9 High <kuid:506034:809673> (JR Payware, Coal Country)
RPPX GP9 High Grey <kuid:506034:8382745> (JR Club Car)
RPPX GP9 High red <kuid:506034:838273> (JR Club Car)
RPPX GP18 <kuid:506034:970572> (JR Payware, Coal Country)
WP GP40 ph2c 1776 <kuid2:37581:10043:1> (JR Club Car)
WP GP40 ph2c 1976 <kuid2:37581:10044:1> (JR Club Car)

Here's what the script menus look like on an affected locomotive (my DTC GP9) in surveyor and driver, respectively:

Can someone please help (preferably Justin as he wrote the script)?
Thank you!

 

[G.M.]

The question is of course,
are the scripts wrong or is the current version of Trainz that gives these errors wrong
for me the answer is clear.
i already had to make an old school version of "Wait of Trigger" because of timeouts
use too many industries and some driver commands no longer work
I have to use TRS2009 to read entries in old route Sessions, because of timeouts
Whenever i bring the subject up during beta testing, I get whacked or plain ignored.

 

[DARTrider]

The question is of course,
are the scripts wrong or is the current version of Trainz that gives these errors wrong
for me the answer is clear.

Honestly, I have no idea, but since other engines with this script aren't affected, but these ones are, I'm guessing its something to do with the locomotive itself. All the JR scripts on my computer other than JointedRail Train Effects library v1.42 (<kuid2:45324:555246:5>) are obsolete, and the locomotives that are breaking are using the v1.42. Replacing these broken scripts with this one does weird things, so I won't try it again.

 

[norfolksouthern37]

I believe the problem to be local to you and caused by something possibly unrelated to the Jr library itself. There must be something not quite right in your install. Maybe try reverting any changes and see if that helps.

The error you have shown can be caused by other things being wrong. There may even be a post already about it somewhere on the forum.

 

[frogpipe]

FWIW, one of the Eagle River woodchip cars (<kuid2:506034:735907:2> ERSX 60Ft.9In. woodchip gondola) was giving me this error when I tried to place it and select a skin in Surveyor (it was placing on the track with the blurry lowres "placeholder" texture that the script is supposed to replace). After some fiddling, I found I had to roll up the trainz-build version of the car to 3.6 from 2.9, and THEN make corrections to make the car compliant to the higher version.

Biggest thing was I needed Pevs tools to make texture.text and tga's from the *.texture files, and had to provide a "b" set of alpha numbers so Content Manager would accept it.

 

[VanEsto]

FWIW, one of the Eagle River woodchip cars (<kuid2:506034:735907:2> ERSX 60Ft.9In. woodchip gondola) was giving me this error when I tried to place it and select a skin in Surveyor (it was placing on the track with the blurry lowres "placeholder" texture that the script is supposed to replace). After some fiddling, I found I had to roll up the trainz-build version of the car to 3.6 from 2.9, and THEN make corrections to make the car compliant to the higher version.

Biggest thing was I needed Pevs tools to make texture.text and tga's from the *.texture files, and had to provide a "b" set of alpha numbers so Content Manager would accept it.

I've been having the same issue with the same car, a lot of the NARM reskins of that car (not a JR problem, but results of the same root cause), and the original BN one it started from. Yet, a few don't suffer the same issue, like a Southern Pacific one that has no issues. Is there a simple line or something that can be copy/pasted or just written into the Config file, or is it a bit more complicated?

If that helps any, running '22 here.

 

[frogpipe]

I'm on 19, and its not complicated IIRC, just tedious.

I opened the car for editing, then copied the folder to my desktop and reverted to original.

Then edited the config to add a :99 to the kuid, and changed the trains-build tag to 3.6

Dragged the folder to content manager and it ingested it as a new revision for the original car. But there were errors. Namely I had to use PevTools to reverse engineer the textures into texture.txt and .tga files, and a few other items (config edits) that were shown when I checked the new, faulty asset for errors with content manager.

I also have a few working examples of woodshop cars from JR and used them as guidance for what the old busted one "should look like".

There was a fair amount of trial and error, including discovering that trainz-build 3.7 messed up the ARN textures. So use 3.6 if you want to try and replicate what I did.

 

[DARTrider]

FWIW, one of the Eagle River woodchip cars (<kuid2:506034:735907:2> ERSX 60Ft.9In. woodchip gondola) was giving me this error when I tried to place it and select a skin in Surveyor (it was placing on the track with the blurry lowres "placeholder" texture that the script is supposed to replace). After some fiddling, I found I had to roll up the trainz-build version of the car to 3.6 from 2.9, and THEN make corrections to make the car compliant to the higher version.

Biggest thing was I needed Pevs tools to make texture.text and tga's from the *.texture files, and had to provide a "b" set of alpha numbers so Content Manager would accept it.

Also having this problem with the UB woodchip car.

 

[sominus]

Hi, I own
RPPX GP9 Chop <kuid:506034:250689> (JR Payware, Coal Country - purchased on Steam)
RPPX GP9 High <kuid:506034:809673> (JR Payware, Coal Country - purchased on Steam)
ATSF GP35u <kuid2:37581:10035:1> (JR Club Car)
Both GP9s work correctly for me in TRS19+SP5 Steam versions. However, ATSF GP35 has a problem - in the driver mod it is not assigned an engineer, the locomotive properties don't work. In the content manager it is not red/buggy. The problem is probably related to the ARN setup script area. This loco represents one particular loco, but unlike for example SD40-2 - CSX #8865 (CR Patched) (JR club car) this GP35 has its number directly in the texture and the model does not even contain ARN textures, while the mentioned SD40 contains ARNs, has them reconfigurable and the script loads its number. For me, all I had to do was to delete all the "uselessness" regarding the ARN from the script and leave in the stuff that all the other locos of this version have. The model works after that. I think the same bug is with EMD GP40 - WP (Bicentennial Pack) (JR club car) - I haven't investigated it further here.
I haven't installed RPPX GP9 High Grey <kuid:506034:8382745> (JR Club Car) and RPPX GP9 High red <kuid:506034:838273> (JR Club Car) yet.

Translated with www.DeepL.com/Translator (free version)

 

[DARTrider]

Sominus, does your ATSF GP35u have yellow lights in the nose? If so you're having an issue I'm having.

 

[sominus]

She hasn't, but she had them before the fix and the RPPX GP9s have them.

 

[JCitron]

There must be something wrong with your setup because everything is fine on my end.

I recommend clearing the cache/libraries folder prior to starting and see if that updates the scripts. If this doesn't, try an EDBR by pressing CTRL while selecting Rebuild database.

 

[sominus]

EMD GP40 - WP (Bicentennial Pack) (JR club car) had same problem as GP35u and RPPX GP9 High Grey <kuid:506034:8382745> (JR Club Car) and RPPX GP9 High red <kuid:506034:838273> (JR Club Car) are OK in my game.

 

[VanEsto]

Ok. I'm running '22, ver. 116492. I checked all items mentioned on this page, and from my collection of stuff, the only ones not working right (but not turning into "red listings") are:
- BTFX woodchip gon
- ERSX woodchip gon
- Utah Belt woodchip gon

However, of the 6 JR Woodchip gons I have, only half aren't working.(An SP, BN, and GRBX ex GN work without issue.) Add to that, tested ALL the RPPX engines (Coal Country and Club Car), the ATSF GP35u, and the WP Bicentennial Pack. All of them work without issue. Proper colored lights, Sand/Fuel working, everything else perfectly fine.

Total weirdness that all of us have similar issues, but not all with the exact same items, but definitely all within a set group of items.

 

[norfolksouthern37]

For me, all I had to do was to delete all the "uselessness" regarding the ARN from the script and leave in the stuff that all the other locos of this version have. The model works after that.

I did find that the included script had items that do not belong to these locomotives. This caused them to stop the script from running when they are placed or spawned. I do not know exactly why trainz never picked up on this before but I corrected the script and files at the site for the following:

<kuid2:37581:10035:1> ATSF GP35u #2964
<kuid2:37581:10043:1> WP GP40 ph2c #1776
<kuid2:37581:10044:1> WP GP40 ph2c #1976
<kuid2:37581:10040:1> DRGW GP40 ph2c

In addition these KUIDs were downloaded right from JR and tested without any issues in TRS19 and TRS22:

BDRV GP7 <kuid:506034:587807> (JR Club Car)
RI GP7R <kuid:506034:450053> (JR Payware)
RPPX GP9 Chop <kuid:506034:250689> (JR Payware, Coal Country)
RPPX GP9 High <kuid:506034:809673> (JR Payware, Coal Country)
RPPX GP9 High Grey <kuid:506034:8382745> (JR Club Car)
RPPX GP9 High red <kuid:506034:838273> (JR Club Car)
RPPX GP18 <kuid:506034:970572> (JR Payware, Coal Country)

These are not broken even if the class marks are showing I think they were just built that way.

Now it appears we have about 3 different issues tangled up in this thread. the ARN code that was not needed was effecting the GP40s. Let's start from there and see what the others comments are about - I am sure they are different things.

 

[DARTrider]

I did find that the included script had items that do not belong to these locomotives. This caused them to stop the script from running when they are placed or spawned. I do not know exactly why trainz never picked up on this before but I corrected the script and files at the site for the following:
<kuid2:37581:10035:1> ATSF GP35u #2964
<kuid2:37581:10043:1> WP GP40 ph2c #1776
<kuid2:37581:10044:1> WP GP40 ph2c #1976
<kuid2:37581:10040:1> DRGW GP40 ph2c

How would I fix this script so it works for these engines?

 

[norfolksouthern37]

How would I fix this script so it works for these engines?

you could download them again or just put this into the folder after opening for edit https://jrpcloud.com/files/team/Users/Justin/temp/jr_loco.gs

or you can open the script itself and make sure it looks like:

include	"fx_loco.gs"


class JRLoco isclass FX_Loco{};

WARNING: applying this to other items mentioned in this thread than those mentioned

<kuid2:37581:10035:1> ATSF GP35u #2964
<kuid2:37581:10043:1> WP GP40 ph2c #1776
<kuid2:37581:10044:1> WP GP40 ph2c #1976
<kuid2:37581:10040:1> DRGW GP40 ph2c

may result in broken or unintended behavior. While this is more often than not the script used for most locomotive items as this file simply tied the code into the train fx library, some do have special features that reside here and clearing the whole class might damage that.

 

[DARTrider]

Thank you! This worked like a charm.

 

[jordon412]

NS37, can you please help us in this thread regarding broken scripts on the woodchip hoppers?
https://forums.auran.com/trainz/showthread.php?168777-ERROR-message-on-JR-60ft-9in-Woodchip-Hopper-loads